Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consistency, fix display of times, update readme, show final results time #1

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

finalcut
Copy link

@finalcut finalcut commented Dec 8, 2020

I made some changes to your fork so figured I'd offer them back to you.

I renamed your new argument of write_weights_file to writeWeightFile to match the orginal authors style for aguments.

Some other changes:

  • fixed time formatting
  • improved time computation for each thread
  • defaulted threads to 4 instead of 2
  • updated readme documentation
  • fixed width of results table to be more readable
  • added new change to show total time across all threads (stolen and modified PR waiting on OP repo)

Hope you can find some use in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant