-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New X509D2iError to improve error checking for X509_ext_get_d2i() #2240
base: master
Are you sure you want to change the base?
New X509D2iError to improve error checking for X509_ext_get_d2i() #2240
Conversation
x509D2iError
to improve error checking for X509_ext_get_d2i()
x509D2iError
to improve error checking for X509_ext_get_d2i()
509D2iError
to improve error checking for X509_ext_get_d2i()
509D2iError
to improve error checking for X509_ext_get_d2i()
Hi @botovq,
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks sensible to me. I do not know when and how this crate is willing to do breaking changes to its public API. Maybe the less brutal way to do it would be to deprecate the existing API and point at new variants that return Result<_, X509D2iError>
. It might even be possible to make the existing API wrappers of the new API that map the X509D2iError
to None
(this has upsides and downsides).
Co-authored-by: Theo Buehler <botovq@users.noreply.github.com>
First try to fix #2226:
New
X509D2iError
which represents the errors that can occur after callingX509_ext_get_d2i()
All corresponding
X509_ext_get_d2i()
calls are adapted accordingly to not return Option<...>, but a Result.ExtensionNotFoundError
is handled asNone
before.If you got other ideas or expectations let me know.