Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translation from label items options #157

Merged
merged 2 commits into from Dec 27, 2022

Conversation

stockiNail
Copy link
Contributor

Fix #156
With CHART.JS version 4.1.0, the _labelitems are changed to be exposed by the method getLabelItems (see chartjs/Chart.js#10966).
the translation array has been moved in labelitem.options.

@sgratzl sgratzl changed the base branch from main to dev December 27, 2022 16:57
@sgratzl
Copy link
Owner

sgratzl commented Dec 27, 2022

thx. can you also change to use the mentioned getLabelItems method instead of _labelItems?

@sgratzl sgratzl added the bug Something isn't working label Dec 27, 2022
@sgratzl sgratzl self-assigned this Dec 27, 2022
@stockiNail
Copy link
Contributor Author

Yes I will change tomorrow. Also the dependency must be changed

@stockiNail
Copy link
Contributor Author

can you also change to use the mentioned getLabelItems method instead of _labelItems?

@sgratzl done!

Also the dependency must be changed

No needed, already set to 4.1.0 when PR to have the method of the scale is included.

@sgratzl sgratzl merged commit 92e1291 into sgratzl:dev Dec 27, 2022
@stockiNail stockiNail deleted the fixDatalabels branch December 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SizeScale: Uncaught TypeError: e.translation is undefined
2 participants