docs(theme): notate source of light-theme hsl vals #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emrosenf is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@emrosenf Can we add the inline comments to the theming doc as well? https://github.com/shadcn/ui/blob/main/apps/www/content/docs/theming.mdx#default |
emrosenf
force-pushed
the
document-theme
branch
from
c7135d3
to
b5aa110
Compare
emrosenf
force-pushed
the
document-theme
branch
from
b5aa110
to
5d2bf00
Compare
emrosenf
force-pushed
the
document-theme
branch
from
5d2bf00
to
8b61c68
Compare
Done. Are we just doing the light theme for now? Some of your dark theme colors are not an exact 1:1 from Tailwind colors. |
|
This could be revisited with the new registry. In colors.ts, each step is defined. You could utilize that for docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comments to
globals.cssto show the origin of the HSL values.Suggested by @its-monotype and @shadcn in response to #185.