-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unused container #2085
base: main
Are you sure you want to change the base?
fix: unused container #2085
Conversation
@onurhan1337 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Following the latest innovations and changes, I sent a new commit to resolve the conflicts. |
For someone who has just started with Tailwind, this can be really confusing. Please take a look and merge it. |
@gaoliang,Thanks a bunch for your support dude, I'm aligned with your perspective. I've been patiently waiting for the merge, but it seems my pull request hasn't caught anyone's eye yet. |
@SoyDiego Please take a look |
I'm only a contributor here. I cannot merge PRs. |
@shadcn Please take a look |
Hey @shadcn, thank you for the review. I brought back the prefix, can you check again? |
I am glad for this PR, now I can actually let this half baked(?) container implementation that confused me go! It was breaking my design. |
this PR removes the unused
container
variable from the theme in the Tailwind CSS configuration and manual install docs.8e6caa1
f2c8d5c
Why it's important
Removing unused code helps keep the codebase clean and easy to maintain. It also reduces confusion for other developers who might wonder where this variable is being used.
IMPORTANT
This pull request is the result of synchronizing my fork with the original repository. It only includes the latest changes I made. The "Sync Fork" operation updates our fork by fetching new commits from the original repository. If there's any confusion or questions, please feel free to reach out.