Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unused container #2085

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

onurhan1337
Copy link
Contributor

@onurhan1337 onurhan1337 commented Dec 10, 2023

this PR removes the unused container variable from the theme in the Tailwind CSS configuration and manual install docs.

8e6caa1
f2c8d5c

Why it's important

Removing unused code helps keep the codebase clean and easy to maintain. It also reduces confusion for other developers who might wonder where this variable is being used.

IMPORTANT

This pull request is the result of synchronizing my fork with the original repository. It only includes the latest changes I made. The "Sync Fork" operation updates our fork by fetching new commits from the original repository. If there's any confusion or questions, please feel free to reach out.

Copy link

vercel bot commented Dec 10, 2023

@onurhan1337 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@onurhan1337 onurhan1337 deleted the fix-unused-container branch December 10, 2023 08:59
@onurhan1337 onurhan1337 restored the fix-unused-container branch December 10, 2023 09:01
@onurhan1337 onurhan1337 changed the title Fix unused container fix: unused container Dec 10, 2023
@onurhan1337 onurhan1337 reopened this Dec 10, 2023
@onurhan1337
Copy link
Contributor Author

Following the latest innovations and changes, I sent a new commit to resolve the conflicts.

@gaoliang
Copy link

gaoliang commented Feb 2, 2024

For someone who has just started with Tailwind, this can be really confusing. Please take a look and merge it.

@onurhan1337
Copy link
Contributor Author

@gaoliang,Thanks a bunch for your support dude, I'm aligned with your perspective. I've been patiently waiting for the merge, but it seems my pull request hasn't caught anyone's eye yet.

@gaoliang
Copy link

gaoliang commented Feb 4, 2024

@SoyDiego Please take a look

@SoyDiego
Copy link
Contributor

SoyDiego commented Feb 4, 2024

@SoyDiego Please take a look

I'm only a contributor here. I cannot merge PRs.

@gaoliang
Copy link

gaoliang commented Feb 4, 2024

@shadcn Please take a look

@onurhan1337
Copy link
Contributor Author

Hey @shadcn, thank you for the review. I brought back the prefix, can you check again?

@onurhan1337 onurhan1337 requested a review from shadcn March 25, 2024 17:16
@Alexander-van-der-Zalm
Copy link

Alexander-van-der-Zalm commented May 1, 2024

I am glad for this PR, now I can actually let this half baked(?) container implementation that confused me go! It was breaking my design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants