Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an enableOffline configuration flag #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aboodman
Copy link

Introduce an enableOffline configuration flag that controls whether offline features work. Defaults to false in dev mode, true in production.

Addresses #143

force offline mode to work. Defaults to false in dev mode, true in
production.

Addresses shadowwalker#143
@shadowwalker
Copy link
Owner

Thanks for the pull request.
This is something I was trying to avoid initially as it adds complexity.
For offline, you can simply verify it works using yarn start instead of yarn dev. Once offline is working, it's working.
During the development mode, most caching rules are disabled to avoid noise when developing other service worker features, such as web push. You will keep online during development mode anyway since hot reloading needs that to work.
Please feel free to argue a scenario where full offline is a must during development.

@ImBIOS
Copy link

ImBIOS commented Nov 9, 2022

This PR is stale, right? @shadowwalker
Do you mind adding this to the backlog or something? I recommend you close this PR if it's not a backlog or something to implement.

@ImBIOS
Copy link

ImBIOS commented May 2, 2023

@aboodman It seems this repo is dead and the maintainer cannot be contacted for so long now. I've made an immediate response by resurrecting this repo ImBIOS/next-pwa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants