Skip to content

Commit

Permalink
ci: Fix player version update on release
Browse files Browse the repository at this point in the history
The v3.2.7 and v3.3.5 releases went out without updating the version
number in lib/player.js.  This fixes the workflow to match the
release-please branch name, and changes the workflow to fail if the
branch name changes again in the future.
  • Loading branch information
joeyparrish committed May 18, 2022
1 parent 9a6f150 commit 4c5109f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/release-please.yaml
Expand Up @@ -28,9 +28,10 @@ jobs:
- name: Custom update Player version
if: steps.release.outputs.release_created == false
run: |
# Check out the branch that release-please created, if it exists.
# Check out the branch that release-please created.
# If it does not exist, FAIL!
git fetch
git checkout release-please--branches--${{ github.ref_name }} || exit 0
git checkout release-please--branches--${{ github.ref_name }}--components--shaka-player || exit 1
# If it does exist, update lib/player.js in the PR branch, so that the
# -uncompiled tag remains in the player version in that context.
VERSION="v$(jq -r .version package.json)-uncompiled"
Expand Down

0 comments on commit 4c5109f

Please sign in to comment.