Skip to content

Commit

Permalink
ci: Fix workflow request for disabled browsers (#6570)
Browse files Browse the repository at this point in the history
You should be able to request a browser explicitly even if it is disabled by default.  This fixed the workflow logic that limited this.
  • Loading branch information
joeyparrish committed May 9, 2024
1 parent 5da5de2 commit 7df5975
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/selenium-lab-tests.yaml
Expand Up @@ -114,11 +114,14 @@ jobs:
continue;
}
// A browser is enabled if it's not disabled and (either the browser
// filter is empty or it contains the browser name).
const enabled = !gridBrowserMetadata[name].disabled &&
(browserFilter.size == 0 ||
browserFilter.has(name.toLowerCase()));
const thisBrowserRequested = browserFilter.has(name.toLowerCase());
const nothingRequested = browserFilter.size == 0;
const thisBrowserOnByDefault = !gridBrowserMetadata[name].disabled;
// A browser is enabled if it's requested, or if it's on by default
// and nothing was requested.
const enabled = thisBrowserRequested ||
(nothingRequested && thisBrowserOnByDefault);
if (enabled) {
include.push({browser: name});
Expand Down

0 comments on commit 7df5975

Please sign in to comment.