Skip to content

Commit

Permalink
test: Improve waitUntilPlayheadReaches function (#6565)
Browse files Browse the repository at this point in the history
  • Loading branch information
avelad committed May 9, 2024
1 parent 4498dcd commit 8830ab7
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions test/test/util/waiter.js
Expand Up @@ -117,17 +117,21 @@ shaka.test.Waiter = class {

// The conditions for success
const p = new Promise((resolve) => {
this.eventManager_.listen(mediaElement, 'timeupdate', () => {
const check = () => {
if (mediaElement.currentTime >= timeGoal || mediaElement.ended) {
this.eventManager_.unlisten(mediaElement, 'timeupdate');
this.eventManager_.unlisten(mediaElement, 'ended');
resolve();
}
});
};
this.eventManager_.listen(mediaElement, 'timeupdate', check);
this.eventManager_.listen(mediaElement, 'ended', check);
});

// The cleanup on timeout
const cleanup = () => {
this.eventManager_.unlisten(mediaElement, 'timeupdate');
this.eventManager_.unlisten(mediaElement, 'ended');
};

return this.waitUntilGeneric_(goalName, p, cleanup, mediaElement);
Expand Down

0 comments on commit 8830ab7

Please sign in to comment.