Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Fix several release workflow bugs
1. When release-please creates release PRs, it removes the -uncompiled tag in the version number in lib/player.js. This adds a step to the workflow to maintain the player.js version manually. 2. This also adds a new job that tags the master branch after a release PR is merged. We maintain the -master tags on the master branch corresponding to each release so that it is easier to manage the range of commits for cherry-picks. 3. The "npm ci" step was failing because our package-lock.json was not compatible with v12 of NodeJS. This updates our workflow to use v16. The npm release workflow has now been tested in a fork up until the publish step. 4. The tagging and GitHub release publication parts of the workflow were previously failing due to an issue with release-please parsing the branch name. This has now been fixed, and is awaiting an upstream merge. For now, we can use my forked version. Closes #3968 (branch parsing failure) Issue #3969 (npm release is now tested up to the publish step) Closes #3971 (master branch tags) Closes #3974 (missing -uncompiled in lib/player.js)
- Loading branch information