FairPlay playback broken in 3.2

[avelad]

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? 3.2

Can you reproduce the issue with our latest release version? Yes

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Both

If custom app, can you reproduce the issue using our demo app? Yes

What browser and OS are you using?
Safari 14.1.1 macOS 11.4

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

U'll send by email

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

Load a FairPlay stream

What did you expect to happen?
The stream load without problem

What actually happened?

Error 6010 is always thrown

I see some problems:

1. https://github.com/google/shaka-player/blob/master/lib/player.js#L2006 should wants instead of has (I'll a send a PR for it)
2. Now due to the use of mediacapabilities, the information is always consulted through mediacapabilties, but this is thinking for MSE, not for SRC =. So here (https://github.com/google/shaka-player/blob/291c93e5fd8a08f69294e533392fa86da249ff5f/lib/media/drm_engine.js#L353) when consulting the FairPlay information it always returns an error.

[avelad]

@joeyparrish @michellezhuogg @theodab
Note: it is a regression in 3.2

[avelad]

I have been doing multiple tests and the problem I see is that HLS is theoretically supported in mediacapabilities with file type, but doing multiple tests I have not gotten it to work :(
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp#L52

[Benny739]

I'm facing the same error, I made 2 codepens:
Working with 3.1.2:
https://codepen.io/benny739/pen/rNmRqLK

Broken with 3.2.0:
https://codepen.io/benny739/pen/XWRGxzy
Error Code: 6010

Also in safari 15 technology preview neither 3.1.2 nor 3.2.0 are working with Fairplay. I'm not sure if fairplay is simply not supported in the tp, as it is in the iOS simulator or if there is a problem with Safari 15.

[avelad]

After doing tests to solve this, it would be best to apply the mediaCapabilities polyfill in Safari (isApple), but if I try to apply it, the following change does not apply:

navigator.mediaCapabilities.decodingInfo =
        shaka.polyfill.MediaCapabilities.decodingInfo_;

@joeyparrish you are more expert in polyfills, can the browser refuse to overwrite a native function?

[theodab]

I tried getting the polyfill to work on Safari, and oddly I found that if you call shaka.polyfill.MediaCapabilities.install() manually in the console, it works. I wonder if something is un-applying our polyfill during the loading process?
The EmeEncryptionSchemePolyfill node module we use does replace navigator.mediaCapabilities.decodingInfo with a shim, but we install that after we install other polyfills, so it shouldn't be able to "see" the original version...

[avelad]

@theodab , I've checked what you say, and with that it works. After the PR #3588, it would only be necessary to solve the installation problem, to close this issue.

[joeyparrish]

Some properties can't be overwritten. I can't do anything to investigate until Monday, but you can try some of the following:

• overwrite the field on navigator.mediaCapabilities
• overwrite navigator.mediaCapabilities itself
• use Object.defineProperties instead of equals
• use delete on the property before setting it
• some combination of these

In my experience, you sometimes just have to try these things and see what the browser lets you get away with.

[avelad]

navigator.mediaCapabilities = /** @type {!MediaCapabilities} */ ({}); produces TypeError: Attempted to assign to readonly property.
delete navigator.mediaCapabilities.decodingInfo does nothing.

[avelad]

I have not found a solution to this. @joeyparrish , can you see if you find it?

[avelad]

@joeyparrish Have you been able to find a solution for this?

[joeyparrish]

Sorry, we do not have a solution for this.

[avelad]

And what is the best solution then? Revert the MediaCapabilities change in 3.2?

[joeyparrish]

With the content you sent us via email, I am currently unable to reproduce the issue. (Safari 14.1.1) I see MediaCapabilities negotiating successfully and instantiating a FairPlay CDM. (The license request fails with an HTTP 500 error, but at least MCap is successful.)

Neither navigator.mediaCapabilities itself nor decodingInfo has been overwritten. The polyfill version persists in my tests.

Is the license request failure I see somehow avoiding the hidden trigger for this issue? Or has it been fixed by Apple since? I have Safari 14.1.1 (16611.2.7.1.4) on macOS 11.4.

[maciejrozanski]

I can reproduce the issue on Safari 14.1.2 and macOS 11.5. After downgrading to shaka-player 3.1.x works fine. I will email you testing materials.

[avelad]

I'm using: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15" (Versión 15.0 (16612.1.29.41.4, 16612)) over macOS 11.6

I will email you another stream