Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support to file type in mediaCapabilities implementation #3570

Merged

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 9, 2021

Maybe related to: #3530

@shaka-bot
Copy link
Collaborator

All tests passed!

@michellezhuogg
Copy link
Contributor

Thank you for your contribution!

  1. Is it possible to add a test with srcEquals set to true?
  2. {boolean} should be good enough for the srcEqual parameter.

@avelad
Copy link
Collaborator Author

avelad commented Aug 11, 2021

@michellezhuogg Done!

@shaka-bot
Copy link
Collaborator

All tests passed!

@michellezhuogg michellezhuogg merged commit 233c2bf into shaka-project:master Aug 16, 2021
@avelad avelad deleted the file-mediacapabilites-support branch August 16, 2021 06:50
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
)

If it's srcEquals, the 'type' element of the input object when querying mediaCapabilities should be 'file'. Otherwise it should be 'media-source' .
Issue: #3530
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
)

If it's srcEquals, the 'type' element of the input object when querying mediaCapabilities should be 'file'. Otherwise it should be 'media-source' .
Issue: #3530

Change-Id: I8d54f5215f27c663ffdcfef0ec41182139d7f5d7
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants