Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some subtitles in the manifest are not shown in the player #3724

Closed
king-prawns opened this issue Oct 29, 2021 · 3 comments · Fixed by #3765 or #4009
Closed

Some subtitles in the manifest are not shown in the player #3724

king-prawns opened this issue Oct 29, 2021 · 3 comments · Fixed by #3765 or #4009
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@king-prawns
Copy link
Contributor

king-prawns commented Oct 29, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.3.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
I loaded the DASH manifest on Shaka demo app on Chrome.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
I can reproduce the bug using a Samsung TV (UT4300, Tizen 5.5) and a DASH Playready manifest

What are the manifest and license server URIs?
This is the important part:

<AdaptationSet mimeType="application/mp4" startWithSAP="1" lang="eng">
      <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
      <Representation id="subtitles/eng/stpp" codecs="stpp" bandwidth="1178"/>
      <SegmentTemplate timescale="1000" initialization="$RepresentationID$/init.mp4" media="$RepresentationID$/seg-$Number$.m4s" startNumber="1">
        <SegmentTimeline>
          <S d="8000" r="974"/>
        </SegmentTimeline>
      </SegmentTemplate>
    </AdaptationSet>
    <AdaptationSet mimeType="application/mp4" startWithSAP="1" lang="ger">
      <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
      <Accessibility schemeIdUri="urn:tva:metadata:cs:AudioPurposeCS:2007" value="2"/>
      <Representation id="subtitles/ger-ad/stpp" codecs="stpp" bandwidth="1172"/>
      <SegmentTemplate timescale="1000" initialization="$RepresentationID$/init.mp4" media="$RepresentationID$/seg-$Number$.m4s" startNumber="1">
        <SegmentTimeline>
          <S d="8000" r="977"/>
        </SegmentTimeline>
      </SegmentTemplate>
    </AdaptationSet>
    <AdaptationSet mimeType="application/mp4" startWithSAP="1" lang="ger">
      <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
      <Representation id="subtitles/ger/stpp" codecs="stpp" bandwidth="1158"/>
      <SegmentTemplate timescale="1000" initialization="$RepresentationID$/init.mp4" media="$RepresentationID$/seg-$Number$.m4s" startNumber="1">
        <SegmentTimeline>
          <S d="8000" r="983"/>
        </SegmentTimeline>
      </SegmentTemplate>
    </AdaptationSet>

I can send you the manifest file via email if needed.

What configuration are you using? What is the output of player.getConfiguration()?
Base config on Shaka demo app

What did you do?
Load the manifest in Shaka demo app

What did you expect to happen?
Shaka should show 3 choice in the caption menu.

What actually happened?
The manifest contains 3 different subtitles but Shaka show only 2 possible choice: "en", "ger".
Shaka ignore the second "ger" subtitle even if the representation id and bandwidth are different.

@king-prawns king-prawns added the type: bug Something isn't working correctly label Oct 29, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Oct 29, 2021
@joeyparrish
Copy link
Member

Do you see all three text tracks in player.getTextTracks()? If so, this is merely a UI issue.

@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Nov 2, 2021
@king-prawns
Copy link
Contributor Author

Do you see all three text tracks in player.getTextTracks()? If so, this is merely a UI issue.

Hey @joeyparrish,
Unfortunately it doesn't seems a UI issue because player.getTextTracks() returns only 2 tracks.

I opened a PR that fix the issue: #3725
there are a couple of solutions.

@king-prawns
Copy link
Contributor Author

king-prawns commented Nov 22, 2021

Hey @joeyparrish,
I opened a second PR with another possible solution to fix the issue: #3765

theodab pushed a commit that referenced this issue Mar 22, 2022
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
joeyparrish pushed a commit that referenced this issue Apr 21, 2022
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
joeyparrish pushed a commit that referenced this issue Apr 21, 2022
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
joeyparrish pushed a commit that referenced this issue Apr 21, 2022
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
3 participants