Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dash): dedup stream logic #3725

Closed
wants to merge 5 commits into from
Closed

fix(dash): dedup stream logic #3725

wants to merge 5 commits into from

Conversation

king-prawns
Copy link
Contributor

@king-prawns king-prawns commented Oct 29, 2021

Description

Fixes #3724

Fix dedup stream logic adding originalId in the filter out condition.
To make it consistent I also added the same for Video, Audio and Image.

Another possible solution could be just add the bandwidth in the filterOutTextStreamDuplicates condition: #3765

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@king-prawns king-prawns changed the title Fix: dedup stream logic fix(dash): dedup stream logic Oct 29, 2021
@avelad
Copy link
Collaborator

avelad commented Mar 22, 2022

@theodab , it was resolved with 0b04aec

@king-prawns king-prawns deleted the fix-dedup-stream branch March 22, 2022 20:11
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some subtitles in the manifest are not shown in the player
3 participants