fix: Do not report MANIFEST RESTRICTIONS_CANNOT_BE_MET error twice #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
May 5, 2022
There was a problem hiding this comment.
It would be nice to have a regression test for this, so that a future refactor doesn't introduce the error again. @albertdaurell, please follow-up with a test that fails without the fix and passes with it.
Thx @joeyparrish. Here it is #4205 |
joeyparrish
pushed a commit
that referenced
this pull request
May 17, 2022
…4194) We want to avoid reporting MANIFEST RESTRICTIONS_CANNOT_BE_MET error twice. This is because when error detected from `onKeyStatus_` calls `updateAbrManagerVariants_` which calls `checkRestrictedVariants_` and error is catched and propagated from `onError_` **but source code execution continues** and `chooseVariantAndSwitch_` triggers same error again: ```javascript onKeyStatus_() { .... if (tracksChanged) { this.updateAbrManagerVariants_(); // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ... if (currentVariant && !currentVariant.allowedByKeySystem) { ... this.chooseVariantAndSwitch_(); // -> chooseVariant_ // -> updateAbrManagerVariants_ // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ``` Closes #4190
joeyparrish
pushed a commit
that referenced
this pull request
May 17, 2022
…4194) We want to avoid reporting MANIFEST RESTRICTIONS_CANNOT_BE_MET error twice. This is because when error detected from `onKeyStatus_` calls `updateAbrManagerVariants_` which calls `checkRestrictedVariants_` and error is catched and propagated from `onError_` **but source code execution continues** and `chooseVariantAndSwitch_` triggers same error again: ```javascript onKeyStatus_() { .... if (tracksChanged) { this.updateAbrManagerVariants_(); // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ... if (currentVariant && !currentVariant.allowedByKeySystem) { ... this.chooseVariantAndSwitch_(); // -> chooseVariant_ // -> updateAbrManagerVariants_ // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ``` Closes #4190
joeyparrish
pushed a commit
that referenced
this pull request
May 17, 2022
…4194) We want to avoid reporting MANIFEST RESTRICTIONS_CANNOT_BE_MET error twice. This is because when error detected from `onKeyStatus_` calls `updateAbrManagerVariants_` which calls `checkRestrictedVariants_` and error is catched and propagated from `onError_` **but source code execution continues** and `chooseVariantAndSwitch_` triggers same error again: ```javascript onKeyStatus_() { .... if (tracksChanged) { this.updateAbrManagerVariants_(); // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ... if (currentVariant && !currentVariant.allowedByKeySystem) { ... this.chooseVariantAndSwitch_(); // -> chooseVariant_ // -> updateAbrManagerVariants_ // -> checkRestrictedVariants_ // -> RESTRICTIONS_CANNOT_BE_MET } ``` Closes #4190
nyanmisaka
added a commit
to nyanmisaka/shaka-player
that referenced
this pull request
Oct 6, 2022
…twice (shaka-project#4194)" This reverts commit 0b03e79.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to avoid reporting MANIFEST RESTRICTIONS_CANNOT_BE_MET error twice.
This is because when error detected from
onKeyStatus_callsupdateAbrManagerVariants_which callscheckRestrictedVariants_and error is catched and propagated fromonError_but source code execution continuesand
chooseVariantAndSwitch_triggers same error again:Resolves
#4190