Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Trigger RESTRICTIONS_CANNOT_BE_MET once from onKeyStatus error #4205

Merged
merged 1 commit into from May 9, 2022
Merged

test: Trigger RESTRICTIONS_CANNOT_BE_MET once from onKeyStatus error #4205

merged 1 commit into from May 9, 2022

Conversation

albertdaurell
Copy link
Contributor

Adding tests for #4194 in order to ensure that, when onKeyStatus({ kid: 'output-restricted'}) error is thrown ONLY one RESTRICTIONS_CANNOT_BE_MET error is triggered/thrown.

This was referenced May 9, 2022
Merged
Merged
@avelad avelad added type: bug Something isn't working correctly component: tests The issue involves our automated tests (generally; otherwise use a more specific component) and removed type: bug Something isn't working correctly labels May 9, 2022
@avelad avelad self-requested a review May 9, 2022 20:32
joeyparrish
joeyparrish approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this fails without the fix and passes with it. Thank you, @albertdaurell, for following up with this regression test!

@joeyparrish joeyparrish merged commit df23e43 into shaka-project:main May 9, 2022
@albertdaurell albertdaurell deleted the test/report-restrictions-cannot-be-met-once branch May 10, 2022 07:33
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@albertdaurell @joeyparrish
test: Trigger RESTRICTIONS_CANNOT_BE_MET once from onKeyStatus error (#…
2ef1177 
…4205)

Adding tests for #4194 in order to ensure that, when `onKeyStatus({ kid: 'output-restricted'})` error is thrown **ONLY** one `RESTRICTIONS_CANNOT_BE_MET` error is triggered/thrown.
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@albertdaurell @joeyparrish
test: Trigger RESTRICTIONS_CANNOT_BE_MET once from onKeyStatus error (#…
1bbb94f 
…4205)

Adding tests for #4194 in order to ensure that, when `onKeyStatus({ kid: 'output-restricted'})` error is thrown **ONLY** one `RESTRICTIONS_CANNOT_BE_MET` error is triggered/thrown.
joeyparrish pushed a commit that referenced this pull request May 17, 2022
@albertdaurell @joeyparrish
test: Trigger RESTRICTIONS_CANNOT_BE_MET once from onKeyStatus error (#…
2720ee4 
…4205)

Adding tests for #4194 in order to ensure that, when `onKeyStatus({ kid: 'output-restricted'})` error is thrown **ONLY** one `RESTRICTIONS_CANNOT_BE_MET` error is triggered/thrown.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertdaurell @joeyparrish @avelad