Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check support for ContentProtection value="cbcs" in DASH #1419

Closed
joeyparrish opened this issue Apr 25, 2018 · 2 comments · Fixed by #6484
Closed

Check support for ContentProtection value="cbcs" in DASH #1419

joeyparrish opened this issue Apr 25, 2018 · 2 comments · Fixed by #6484
Assignees
@avelad
Labels
component: DASH The issue involves the MPEG DASH manifest format component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release type: enhancement New feature or request
Milestone
v4.9

Comments

@joeyparrish
Copy link
Member

Currently, Chrome (66) only supports "cenc" encryption, not "cbcs". There are clues in a DASH manifest when other encryption schemes are used. For example:

<ContentProtection value="cbcs" schemeIdUri="urn:mpeg:dash:mp4protection:2011" />

We should check for this and reject content using an unsupported encryption scheme.

Here is an example of such content:

https://storage.googleapis.com/shaka-demo-assets/sintel-cbcs/dash.mpd

https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/sintel-cbcs/dash.mpd;license=https://cwip-shaka-proxy.appspot.com/no_auth;lang=en-US;build=uncompiled

This relates to the following proposed extension to EME: https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md

This information could some day be used to query the browser for support, rather than just rejecting any content not using "cenc".
@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 25, 2018
@shaka-bot shaka-bot added this to the Backlog milestone Apr 25, 2018
@philhar
Copy link

philhar commented May 10, 2018

As an aside, this stream stops after 10s in Chrome 68:

Shaka Error MEDIA.VIDEO_ERROR (3,,PIPELINE_ERROR_DECODE: DecryptingDemuxerStream: decrypt error)

@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@joeyparrish joeyparrish added priority: P2 Smaller impact or easy workaround component: EME The issue involves the Encrypted Media Extensions web API labels Oct 4, 2021
@avelad avelad added the component: DASH The issue involves the MPEG DASH manifest format label May 3, 2022
@joeyparrish joeyparrish mentioned this issue Feb 28, 2024
Merged
@joeyparrish joeyparrish self-assigned this Feb 28, 2024
@joeyparrish joeyparrish modified the milestones: Backlog, v5.0 Feb 28, 2024
@joeyparrish joeyparrish added priority: P1 Big impact or workaround impractical; resolve before feature release and removed priority: P2 Smaller impact or easy workaround labels Feb 28, 2024
@joeyparrish
Copy link
Member Author

joeyparrish commented Feb 28, 2024 •
edited

Bumping priority so that we can detect encryption scheme support and properly reject content that can't be decrypted correctly. The current situation of garbage decryptions and decoder errors is not good.

See also comments in #6308

@avelad avelad mentioned this issue Apr 25, 2024
Merged
avelad added a commit that referenced this issue Apr 26, 2024
@avelad
feat: Add encryptionScheme to shaka.extern.DrmInfo (#6480)
c6c39df 
Related to #1419
@avelad avelad mentioned this issue Apr 26, 2024
Merged
avelad added a commit that referenced this issue Apr 26, 2024
@avelad
feat: Add encryptionScheme support on MCap polyfill (#6482)
5a0e60a 
Related to #1419
@avelad avelad mentioned this issue Apr 26, 2024
Merged
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@avelad avelad assigned avelad and unassigned joeyparrish Apr 26, 2024
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Apr 29, 2024
@joeyparrish
feat: Add support for probing encryption scheme support
76e3edc 
This will add encryption schemes to the DRM support report generated
by probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR shaka-project#6484,
and issue shaka-project#1419.
@joeyparrish joeyparrish mentioned this issue Apr 29, 2024
Merged
avelad added a commit that referenced this issue May 6, 2024
@joeyparrish @avelad
feat: Add support for probing encryption scheme support (#6506)
2dea350 
This will add encryption schemes to the DRM support report generated by
probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR #6484,
and issue #1419.

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad added a commit that referenced this issue May 8, 2024
@avelad
feat: Check encryptionScheme against MCap (#6484)
ec29f82 
Closes #1419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avelad avelad

Labels
component: DASH The issue involves the MPEG DASH manifest format component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release type: enhancement New feature or request
Projects
None yet
Milestone
v4.9
Development

Successfully merging a pull request may close this issue.

feat: Check encryptionScheme against MCap avelad/shaka-player
4 participants
@joeyparrish @avelad @shaka-bot @philhar