Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for probing encryption scheme support #6506

Merged
merged 4 commits into from May 6, 2024

Conversation

joeyparrish
Copy link
Member

This will add encryption schemes to the DRM support report generated by probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR #6484, and issue #1419.

This will add encryption schemes to the DRM support report generated
by probeSupport() and support.html.

Related to shaka-project/eme-encryption-scheme-polyfill#62, PR shaka-project#6484,
and issue shaka-project#1419.
@joeyparrish
Copy link
Member Author

Hrm... The probe might be broken on Safari... Moving to draft status.

@joeyparrish joeyparrish marked this pull request as draft April 29, 2024 23:16
@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 29, 2024

Incremental code coverage: 98.13%

@avelad avelad marked this pull request as ready for review April 30, 2024 14:30
@avelad
Copy link
Collaborator

avelad commented Apr 30, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6506

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Apr 30, 2024
@avelad avelad added this to the v4.9 milestone Apr 30, 2024
@avelad avelad self-requested a review April 30, 2024 15:16
lib/media/drm_engine.js Outdated Show resolved Hide resolved
lib/media/drm_engine.js Outdated Show resolved Hide resolved
@avelad
Copy link
Collaborator

avelad commented May 6, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6506

@avelad avelad merged commit 2dea350 into shaka-project:main May 6, 2024
29 of 30 checks passed
@joeyparrish joeyparrish deleted the probe-encryption-schemes branch May 6, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants