docs: update fairplay.md
#3562
Closed
docs: update fairplay.md
#3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joeyparrish, this PR is ready for review. |
TheModMaker
reviewed
Aug 24, 2021
docs/tutorials/fairplay.md
Outdated
|
|
||
| ## DRM Engine | ||
|
|
||
| Some FairPlay support needs to be detected in order to change source to HLS if FairPlay is supported (AFAIK currently FairPlay is supported only within HLS and not publicly supported in DASH). You can query EME yourself, directly, and only query FairPlay, rather than the full list of key systems probed by `DrmEngine`. |
There was a problem hiding this comment.
Split lines at 80 characters. Also, there's no need to mention DrmEngine; you could say probeSupport instead.
| Some FairPlay support needs to be detected in order to change source to HLS if FairPlay is supported (AFAIK currently FairPlay is supported only within HLS and not publicly supported in DASH). You can query EME yourself, directly, and only query FairPlay, rather than the full list of key systems probed by `DrmEngine`. | ||
|
|
||
| ```js | ||
| async function isFairPlaySupported() { |
There was a problem hiding this comment.
It may be a good idea to add this to shaka.util.FairPlayUtils so apps can just call this function.
There was a problem hiding this comment.
Should I go ahead and add it to fairplay_utils.js?
@TheModMaker Please review the changes
joeyparrish
pushed a commit
that referenced
this pull request
Mar 16, 2022
This adds 3 new methods to FairPlayUtils: - isFairPlaySupported --> Closes PR #3562 - spcFairPlayRequest --> This method adds basic spc FairPlay request filter - commonFairPlayResponse --> This method adds a basic FairPlay response filter that supports a lot of DRM providers.
|
#4029 appears to make most of this obsolete. Please update the PR or close it. Thanks! |
joeyparrish
added
the
status: waiting on response
github-actions
bot
added
the
status: archived
github-actions
bot
removed
the
status: waiting on response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3541
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass