Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always polyfill MediaCapabilities for Apple browsers #3588

Merged
merged 3 commits into from Aug 21, 2021
Merged

Always polyfill MediaCapabilities for Apple browsers #3588

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2348146
Always polyfill MediaCapabilities for Apple browsers
Aug 20, 2021
6a41030
Fix line length
Aug 20, 2021
f0b0d3b
Change comment
Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/polyfill/media_capabilities.js
View file
Open in desktop
Expand Up @@ -27,7 +27,14 @@ shaka.polyfill.MediaCapabilities = class {
// Since MediaCapabilities is not fully supported on Chromecast yet, we
// should always install polyfill for Chromecast.
// TODO: re-evaluate MediaCapabilities in the future versions of Chromecast.
if (!shaka.util.Platform.isChromecast() && navigator.mediaCapabilities) {
// Since MediaCapabilities implementation is buggy in Apple browsers, we
// should always install polyfill for Apple browsers.
// See: https://github.com/google/shaka-player/issues/3530
// TODO: re-evaluate MediaCapabilities in the future versions of Apple
// Browsers.
if (!shaka.util.Platform.isChromecast() &&
!shaka.util.Platform.isApple() &&
navigator.mediaCapabilities) {
shaka.log.debug(
'MediaCapabilities: Native mediaCapabilities support found.');
return;
Expand Down