Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add explicit release() for FakeEventTarget #3950

Merged
merged 1 commit into from Feb 15, 2022
Merged

fix: Add explicit release() for FakeEventTarget #3950

merged 1 commit into from Feb 15, 2022

Commits on Feb 14, 2022

  1. fix: Add explicit release() for FakeEventTarget 

    Before, we would count on all event listeners for FakeEventTargets to
be cleaned up by the object that listens.  Now, FakeEventTarget
implements IReleasable, so that all listeners are removed when owners
call release().

For objects extending FakeEventTarget and also implementing
IDestroyable, the destroy() methods will call out to super.release()
to clean up listeners then.  The owner should use destroy() in those
cases.

Issue #3949 (memory leak in DASH live streams with inband EventStream)
    @joeyparrish
    joeyparrish committed Feb 14, 2022
    Copy the full SHA
    fa8a33b View commit details
    Browse the repository at this point in the history