Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text): Fix webvtt offset in sequence mode #3955

Merged
merged 1 commit into from Feb 16, 2022
Merged

fix(text): Fix webvtt offset in sequence mode #3955

merged 1 commit into from Feb 16, 2022

Commits on Feb 16, 2022

  1. fix(text): Fix webvtt offset in sequence mode 

    When running in sequence mode, we ignore the normal timestamps
of video and audio segments. This lead to problems in some Apple-
encoded webvtt content, which used the X-TIMESTAMP-MAP tag to account
for the timestamp offsets in their video. Thus, those subtitles would
end up 10 seconds offset.
This changes the webvtt parser to ignore the X-TIMESTAMP-MAP when in
sequence mode.

Issue shaka-project#2337

Change-Id: I1596e064be42ad8fb536729816a64514dac07c3e
    @theodab
    theodab committed Feb 16, 2022
    Copy the full SHA
    858fe4a View commit details
    Browse the repository at this point in the history