Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix memory leak in DASH live streams with inband EventStream #3957

Merged
merged 1 commit into from Feb 16, 2022
Merged

fix: Fix memory leak in DASH live streams with inband EventStream #3957

merged 1 commit into from Feb 16, 2022

Commits on Feb 16, 2022

  1. fix: Fix memory leak in DASH live streams with inband EventStream 

    EventStreams in DASH generate TimelineRegionInfo objects, which are
then stored in the RegionTimeline and RegionObserver classes.  But
DashParser would add all regions to RegionTimeline, even if they would
be quickly removed again, and RegionObserver would cache some regions
from the timeline without ever removing them.

This fixes the issue from both of those directions.  DashParser will
now ignore regions that are outside the DVR window (and therefore
would soon be removed from RegionTimeline), and RegionObserver listens
to an event on RegionTimeline to clean up its own storage when regions
fall outside the DVR window during playback.

Closes #3949 (memory leak in DASH live streams with inband EventStream)
    @joeyparrish
    joeyparrish committed Feb 16, 2022
    Copy the full SHA
    cd9feae View commit details
    Browse the repository at this point in the history