Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix playRangeEnd for certain content #4068

Merged
merged 2 commits into from Mar 29, 2022
Merged

fix: Fix playRangeEnd for certain content #4068

merged 2 commits into from Mar 29, 2022

Commits on Mar 28, 2022

  1. fix: Fix playRangeEnd for certain content 

    For content where the manifest parser uses the notifySegments API
(DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH
SegmentTemplate+duration), the Player seekRangeEnd configuration was
not being honored correctly.

This fixes the issue in PresentationTimeline and adds a regression
test to our playRangeStart/playRangeEnds tests.

Fixed shaka-project#4026
    @joeyparrish
    joeyparrish committed Mar 28, 2022
    Copy the full SHA
    8c85bd3 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Responding to feedback 

     - Update jsdoc in Timeline
 - reorganize and add comments to tests to clarify
    @joeyparrish
    joeyparrish committed Mar 29, 2022
    Copy the full SHA
    fbe9b6c View commit details
    Browse the repository at this point in the history