fix(performance): Eliminate use of ES6 generators #4075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
reviewed
Mar 30, 2022
| @@ -96,11 +98,17 @@ shaka.util.Iterables = class { | |||
| * - The previous item in the list, if it exists. | |||
| * | |||
| * @param {!Iterable.<T>} iterable | |||
| * @return {!Iterable.< | |||
| * {i: number, item: T, prev: (T|undefined), next: (T|undefined)}>} | |||
| * @return {!Array.<{ | |||
There was a problem hiding this comment.
This is a drop-in replacement that doesn't require the call sites to change, which is why I did it this way. It was the easiest change to make. But if a big part of our performance problem is GC, we should probably avoid creating additional arrays.
In some cases, we could rewrite the call sites if a simple for loop would suffice. Or if we want to keep a functional style, we could accept a callback to be invoked on each item in the enumeration.
There was a problem hiding this comment.
I created a new PR from my repo #4092
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4062 (comment)
Author: @joeyparrish