Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dash): Fix playback of Dolby Atmos #4173

Merged
merged 1 commit into from Apr 29, 2022
Merged

fix(dash): Fix playback of Dolby Atmos #4173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/dash/dash_parser.js
View file
Open in desktop
Expand Up @@ -1229,7 +1229,6 @@ shaka.dash.DashParser = class {
});
let spatialAudio = false;
if (hasJoc) {
context.representation.mimeType = 'audio/eac3-joc';
spatialAudio = true;
}

Expand Down
24 changes: 0 additions & 24 deletions test/dash/dash_parser_manifest_unit.js
View file
Open in desktop
Expand Up @@ -447,30 +447,6 @@ describe('DashParser Manifest', () => {
expect(stream.closedCaptions).toEqual(expectedClosedCaptions);
});

it('Detects E-AC3 JOC content by SupplementalProperty', async () => {
const idUri = 'tag:dolby.com,2018:dash:EC3_ExtensionType:2018';
const source = [
'<MPD>',
' <Period duration="PT30M">',
' <AdaptationSet mimeType="audio/mp4" lang="\u2603">',
' <Representation bandwidth="500">',
' <SupplementalProperty schemeIdUri="' + idUri + '" value="JOC"/>',
' <BaseURL>http://example.com</BaseURL>',
' <SegmentTemplate media="2.mp4" duration="1" />',
' </Representation>',
' </AdaptationSet>',
' </Period>',
'</MPD>',
].join('\n');

fakeNetEngine.setResponseText('dummy://foo', source);

/** @type {shaka.extern.Manifest} */
const manifest = await parser.start('dummy://foo', playerInterface);
const stream = manifest.variants[0].audio;
expect(stream.mimeType).toBe('audio/eac3-joc');
});

it('Detects spatial audio', async () => {
const idUri = 'tag:dolby.com,2018:dash:EC3_ExtensionType:2018';
const source = [
Expand Down