Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix UI duration time #4734

Closed
wants to merge 1 commit into from
Closed

fix(UI): Fix UI duration time #4734

wants to merge 1 commit into from

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 21, 2022

Closes #3657

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Nov 21, 2022
@avelad avelad added this to the v4.4 milestone Nov 21, 2022
@avelad avelad mentioned this pull request Nov 21, 2022
Closed
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

joeyparrish
joeyparrish requested changes Dec 6, 2022
View reviewed changes
ui/presentation_time.js
const seekRange = this.player.seekRange();
const duration = seekRange.end - seekRange.start;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this more correct? I would expect this to be a no-op for VOD, and the live branch doesn't use duration at all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to explain it very well, but in my empirical tests it gives better results because it does not take into account the initial gaps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does VOD HLS in sequence mode have initial gaps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Lubjan Lubjan mentioned this pull request Dec 7, 2022
Closed
@Lubjan
Copy link

Lubjan commented Dec 7, 2022 •
edited

I added a comment to the initial issue (#3657) this PR is linked to and tried the change locally in my companies project, both problems of the issue still occur.

@joeyparrish
Copy link
Member

@avelad, according to @Lubjan, this doesn't seem to fix the issue. Also, I don't understand how this change would make any difference. So I'm inclined to close this PR. Thoughts?

@avelad avelad closed this Dec 7, 2022
@avelad avelad deleted the ui-duration branch December 8, 2022 17:55
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish requested changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Incorrect behavior on large HLS clips
3 participants
@avelad @Lubjan @joeyparrish