Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add chapter titles and dividers on the seek bar #5863

Merged
merged 5 commits into from Nov 8, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 7, 2023

Closes #3597

BEGIN_COMMIT_OVERRIDE
Reverted, please ignore
END_COMMIT_OVERRIDE

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P4 Nice to have / wishful thinking labels Nov 7, 2023
@avelad avelad added this to the v4.6 milestone Nov 7, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 7, 2023

Incremental code coverage: 48.21%

ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 8, 2023 08:19
# Conflicts:
#	ui/seek_bar.js
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this new approach looks better.
I do have a few more requests though.

lib/player.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 8, 2023 08:48
ui/seek_bar.js Show resolved Hide resolved
@avelad avelad requested a review from theodab November 8, 2023 08:57
@avelad avelad merged commit c1198df into shaka-project:main Nov 8, 2023
15 of 16 checks passed
@Trail3lazer
Copy link

It looks like my changes from #5771 were copied, modified and then merged with this PR. Please link my commits and add me as a contributor.

@avelad avelad deleted the ui-chapters branch November 13, 2023 08:02
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 7, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 7, 2024
@avelad
Copy link
Collaborator Author

avelad commented Feb 1, 2024

@Trail3lazer I'm going to revert the funcionality and you can work on it. #6208

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chapter marks in the seek bar
4 participants