Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix waiting for empty init datas #6292

Merged
merged 6 commits into from Feb 27, 2024
Merged

fix: Fix waiting for empty init datas #6292

merged 6 commits into from Feb 27, 2024

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Feb 24, 2024

Issue #6228

@theodab theodab added type: bug Something isn't working correctly component: offline The issue involves the offline storage system of Shaka Player labels Feb 24, 2024
@theodab
Copy link
Collaborator Author

theodab commented Feb 24, 2024

This fixes (?) and issue that I found while investigating #6228.

As I did not reproduce the exact issue that reporter had, and they did not reproduce the issue I had, it is possible this is a platform-specific problem, maybe based on macOS versions. It's hard to say.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad added this to the v5.0 milestone Feb 26, 2024
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Feb 26, 2024
joeyparrish
joeyparrish requested changes Feb 26, 2024
View reviewed changes
lib/media/drm_engine.js Outdated Show resolved Hide resolved
joeyparrish
joeyparrish requested changes Feb 27, 2024
View reviewed changes
test/media/drm_engine_unit.js Outdated Show resolved Hide resolved
@joeyparrish
Copy link
Member

@shaka-bot please test

@shaka-bot
Copy link
Collaborator

@joeyparrish: Lab tests started with arguments:

  • pr=6292

@joeyparrish
Copy link
Member

I merged main into this branch to fix flaky tests and other issues, and now I'm rerunning the lab tests to validate that the timeout is sufficient.

@shaka-bot please test

@shaka-bot
Copy link
Collaborator

@joeyparrish: Lab tests started with arguments:

  • pr=6292

@joeyparrish
Copy link
Member

I'll merge once I see tests pass in the lab.

@joeyparrish joeyparrish merged commit 118f47f into shaka-project:main Feb 27, 2024
30 checks passed
@shaka-bot shaka-bot mentioned this pull request Feb 27, 2024
Merged
@theodab theodab deleted the offlineFailingSilentlyBranch branch February 27, 2024 21:02
@theodab theodab mentioned this pull request Mar 12, 2024
Closed
avelad pushed a commit that referenced this pull request Apr 8, 2024
@theodab @avelad
fix: Fix waiting for empty init datas (#6292)
4fa32b0 
Issue #6228
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad pushed a commit that referenced this pull request Apr 8, 2024
@theodab @avelad
fix: Fix waiting for empty init datas (#6292)
e75505a 
Issue #6228
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theodab @shaka-bot @joeyparrish @avelad