ci: Improve CI status setting #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joeyparrish
commented
Feb 27, 2024
joeyparrish
commented
- Link CI status to specific jobs, not just the run
- Split selenium job status flag away from ignore_test_status (which is for getting screenshots)
- Remove redundant status setting step in update-screenshots
- Fix final status computation in update-screenshots to account for edge cases and old typo
- Link CI status to specific jobs, not just the run - Split selenium job status flag away from ignore_test_status (which is for getting screenshots) - Remove redundant status setting step in update-screenshots - Fix final status computation in update-screenshots to account for edge cases and old typo
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Oops, found a bug via my test run on my fork... I'll make this a draft for now. |
joeyparrish
removed request for
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Fixed & verified on my fork. Ready for review. PTAL! |
alekzz
approved these changes
Feb 27, 2024
avelad
pushed a commit
that referenced
this pull request
Apr 8, 2024
- Link CI status to specific jobs, not just the run - Split selenium job status flag away from ignore_test_status (which is for getting screenshots) - Remove redundant status setting step in update-screenshots - Fix final status computation in update-screenshots to account for edge cases and old typo
avelad
pushed a commit
that referenced
this pull request
Apr 8, 2024
- Link CI status to specific jobs, not just the run - Split selenium job status flag away from ignore_test_status (which is for getting screenshots) - Remove redundant status setting step in update-screenshots - Fix final status computation in update-screenshots to account for edge cases and old typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.