Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix test infra failure on non-ES6 devices #6577

Merged
merged 1 commit into from May 10, 2024

Conversation

joeyparrish
Copy link
Member

Splitting code from test/test/boot.js into proxy-cast-platform.js caused issues with non-ES6 devices because the new file did not match the list of files run through Babel before being served by Karma.

Splitting code from test/test/boot.js into proxy-cast-platform.js caused issues with non-ES6 devices because the new file did not match the list of files run through Babel before being served by Karma.
@joeyparrish
Copy link
Member Author

Confirmed privately in the lab with --filters StringUtil --browsers Tizen.

@joeyparrish joeyparrish merged commit 03ee77e into shaka-project:main May 10, 2024
18 of 20 checks passed
@joeyparrish joeyparrish deleted the fix-tizen-test-failure branch May 10, 2024 16:39
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

avelad pushed a commit that referenced this pull request May 13, 2024
Splitting code from test/test/boot.js into proxy-cast-platform.js caused issues with non-ES6 devices because the new file did not match the list of files run through Babel before being served by Karma.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants