test: Fix Fuchsia background-video errors #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, Fuchsia Chromecast tests will fail with the error: "The play() request was interrupted because video-only background media was paused to save power." This resolves the issue by ensuring tests run un-muted on that platform, based on this Chrome code, which indicates the "paused to save power" logic does not activate when sound is playing: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/media/web_media_player_impl.cc;l=3535;drc=d23075f3
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: 100.00% |
theodab
approved these changes
May 11, 2024
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
In some cases, Fuchsia Chromecast tests will fail with the error: "The play() request was interrupted because video-only background media was paused to save power." This resolves the issue by ensuring tests run un-muted on that platform, based on this Chrome code, which indicates the "paused to save power" logic does not activate when sound is playing: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/media/web_media_player_impl.cc;l=3535;drc=d23075f3 This also fixes two places in our tests where the `createVideoElement()` was bypassed. This should always be used, because it is a central place to apply workarounds such as this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Fuchsia Chromecast tests will fail with the error: "The play() request was interrupted because video-only background media was paused to save power."
This resolves the issue by ensuring tests run un-muted on that platform, based on this Chrome code, which indicates the "paused to save power" logic does not activate when sound is playing: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/media/web_media_player_impl.cc;l=3535;drc=d23075f3
This also fixes two places in our tests where the
createVideoElement()was bypassed. This should always be used, because it is a central place to apply workarounds such as this.