ci: Add overall test timeout of 30 minutes #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: No instrumented code was changed. |
|
This doesn't seem to be working yet... |
joeyparrish
removed request for
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
joeyparrish
force-pushed
the
set-test-timeout
branch
from
fc8e2e7
to
dd88c48
Compare
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
I didn't see this working before because the Selenium lab workflow normally runs against the workflow from |
avelad
approved these changes
May 11, 2024
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
When tests occasionally timeout (as is currently happening with IndexedDB hangs on Mac), we should stop the test run after 30 minutes and allow the "deflake" workflow to rerun them. Without this timeout, the test run can takes hours. A successful test run takes 15-20 minutes currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests occasionally timeout (as is currently happening with IndexedDB hangs on Mac), we should stop the test run after 30 minutes and allow the "deflake" workflow to rerun them. Without this timeout, the test run can takes hours.
A successful test run takes 15-20 minutes currently.