Electron 10 #39
Merged
Electron 10 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade default electron-builder to 22.9.1 upgrade default electron-packager to 15.1.0
VictoriaTheBrave
approved these changes
Nov 9, 2020
| @@ -52,7 +52,8 @@ function* iterate(array) { | |||
| * @param {string} filePath - path to the file being sent | |||
| */ | |||
| function createReadStream(filePath) { | |||
| if (parseInt(process.versions.electron) >= 7) { | |||
| if (parseInt(process.versions.electron) >= 7 | |||
| && parseInt(process.versions.electron) < 10) { | |||
There was a problem hiding this comment.
Are you sure it is not needed for 10th version?
There was a problem hiding this comment.
looks like electron/electron#21018 not reproduced in 10.x.x
This reverts commit d48a8f4
VictoriaTheBrave
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch18481]