pull request for issue 78 #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
============================================
- Coverage 98.87% 98.79% -0.08%
- Complexity 202 222 +20
============================================
Files 3 4 +1
Lines 4183 4245 +62
Branches 55 66 +11
============================================
+ Hits 4136 4194 +58
Misses 24 24
- Partials 23 27 +4
Continue to review full report at Codecov.
|
|
@flube2 I have started review of this PR. Will try to do it by EOD |
|
Ok let me know if there are any changes you would like me to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a software design class we were to write a patch, whether it was accepted or not. Due to this, we implemented the code for this issue before submitting a pull request. If changes are needed, let me know.
StrmanTests.java - Test cases created and added to file
NumberFormatOptions.java - Created for implementing formatting options
Strman.java - formatNumber() implemented
The only huge deviation so far is that the desired argument passed to the formatNumber() function was listed on shekargulati/strman-java as type "long". This will not work with decimal numbers. Changing it to "double" solves all problems that we had encountered.