Skip to content

Commit

Permalink
chore: update nyc to v15
Browse files Browse the repository at this point in the history
No change to logic. This updates nyc (code coverage tool) to version 15,
which works around a breaking change that snuck into the latest Node LTS
versions.

Unfortunately, this version of nyc appears to break Node 8 and 9. We
need to work around this problem by skipping test coverage on those
versions.

Fixes #1130
  • Loading branch information
nfischer committed Nov 12, 2023
1 parent e7ce4df commit f5c6bb5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,20 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run test-with-coverage
- name: test with coverage
run: npm run test-with-coverage
if: matrix.node-version >= 10
- name: test without coverage (coverage broken on node < 10)
run: npm run test
if: matrix.node-version < 10
- run: npm run lint
- run: npm run gendocs
- run: npm run check-node-support
- name: Check for modified files (skip on Windows)
run: npm run after-travis
if: matrix.os != 'windows-latest'
- name: Upload coverage reports to Codecov
if: matrix.node-version >= 10
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,12 @@
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.17.3",
"js-yaml": "^3.14.1",
"nyc": "^14.1.1",
"nyc": "^15.1.0",
"shelljs-changelog": "^0.2.6",
"shelljs-release": "^0.5.2",
"shx": "^0.3.4",
"travis-check-changes": "^0.4.0"
},
"optionalDependencies": {},
"engines": {
"node": ">=8"
}
Expand Down

0 comments on commit f5c6bb5

Please sign in to comment.