Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos #1137

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fixing typos #1137

merged 1 commit into from
Nov 13, 2023

Conversation

deining
Copy link
Contributor

@deining deining commented Nov 10, 2023

This PR fixes a few typos that I spotted in the project. I will sign my commit soon.

@deining
Copy link
Contributor Author

deining commented Nov 11, 2023

The commit is signed now.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is awesome!

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
plugin.js 100.00% <ø> (ø)
src/dirs.js 97.18% <ø> (ø)
src/sed.js 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!

@nfischer
Copy link
Member

Can you please rebase on top of the latest master branch? I made some changes today to fix up the tester bots.

@deining
Copy link
Contributor Author

deining commented Nov 12, 2023

Can you please rebase on top of the latest master branch?

Done.

@nfischer nfischer merged commit 6269733 into shelljs:master Nov 13, 2023
41 checks passed
@deining deining deleted the fix-typos branch November 13, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants