Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch to fast-glob #1153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: switch to fast-glob #1153

wants to merge 2 commits into from

Commits on Feb 18, 2024

  1. deprecate config.globOptions 

    This removes support for configuring `config.globOptions`. Exposing this
variable makes it difficult to change (or upgrade) our glob library.
It's best to consider our choice of glob library to be an implementation
detail.

As far as I know, this is not a commonly used option:
https://github.com/shelljs/shelljs/issues?q=globOptions currently shows
no GitHub issues of users using this option, and there was never really
a motivation for why this needed to be exposed (#400 exposed the option
just because we could, not because we should).

This is one step toward supporting Issue #828.
    @nfischer
    nfischer committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    7cad93a View commit details
    Browse the repository at this point in the history

  2. feat: switch to fast-glob 

    This removes `node-glob` in favor of `fast-glob`. The main motivation
for this is because `node-glob` has a security warning and I can't
update to `node-glob@9` unless we drop compatibility for node v8.

Switching to `fast-glob` seems to be fairly straightforward, although
some options need to be changed by default for bash compatibility.

Fixes #828
Fixes #1149
    @nfischer
    nfischer committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    3015415 View commit details
    Browse the repository at this point in the history