Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report forgotten errors from 'mv' #879

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Report forgotten errors from 'mv' #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d3999
Report forgotten errors from 'mv'.
vgalka-sl Jul 23, 2018
898deb6
Fixed spacing.
vgalka-sl Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ function _mv(options, sources, dest) {
// exception to pass up to the top level.
cp('-r', src, thisDest);
rm('-rf', src);
} else {
common.error(e.message, { continue: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you catch a specific e.code and output a message like mv: cannot move 'foo/a/file.js' to 'bar/a/file.js': No such file or directory?

Also, could you add an else branch with throw e? The distinction is that we only want to use common.error() for expected error conditions, and would prefer to fail loudly with an exception for unexpected conditions (so that we can fix these as they're reported).

}
}
}); // forEach(src)
Expand Down