Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): fixes import order lint warnings #215

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Aug 5, 2023

I can't reproduce these warnings locally, but these appear to be failing on CI. This is a speculative fix.

@nfischer nfischer added the chore label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (05db932) 100.00% compared to head (cd5c32c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          114       114           
=========================================
  Hits           114       114           
Files Changed Coverage Δ
src/shx.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I can't reproduce these warnings locally, but these appear to be failing
on CI. This is a speculative fix.

I also noticed that eslint-import-resolver-node updated today but has a
breaking change that breaks node v6 compatibility. I'm adding this to
devDependencies to pin this to the last non-broken version.
@nfischer nfischer merged commit 0cb9065 into main Aug 5, 2023
80 checks passed
@nfischer nfischer deleted the fix-lint-errors branch August 5, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant