Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mocha V10 #48

Closed
wants to merge 12 commits into from
Closed

Upgrade to Mocha V10 #48

wants to merge 12 commits into from

Conversation

alehuo
Copy link

@alehuo alehuo commented Mar 21, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Mocha v10 has dropped Node.js v12 support. Also, using mocha-chrome to test projects that do not call mocha.setup will have to be migrated. I have updated the documentation to reflect this change.

This library is now pure ESM. No CommonJS support. If we want to still support CommonJS, we could setup Parcel to bundle both CommonJS and ESM. Maybe add a notification to README.md because of this?

Please Describe Your Changes

  • Bump library version to v3.0.0
  • Use Node.js v16 LTS in the project
  • Upgrade project dependencies
  • Remove outdated ESLint configuration to support ES Modules
  • Upgrade Mocha 6 to Mocha 10
  • Reviewed and fixed tests accordingly. Mocha v10 introduced some API changes that made a few tests breaks.
  • One dependency upgrade required that the codebase was transformed into ESM

This PR has been tested in a large-scale project which needed updates to its dependencies. Mocha-chrome was one dependency that included a security vulnerability which required Mocha to be updated to v10. I'm happy to assist in further improvements to the library.

Relevant pull requests: #45 #47

@alehuo
Copy link
Author

alehuo commented Mar 23, 2023

I will reopen this PR, when I have investigated why CI started failing tests that use mocha-chrome. Locally all seems to be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant