Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mini-css-extract-plugin 0.4.3 issue #176

Closed
wants to merge 2 commits into from
Closed

Fix mini-css-extract-plugin 0.4.3 issue #176

wants to merge 2 commits into from

Commits on Nov 13, 2018

  1. Fix mini-css-extract-plugin 0.4.3 issue 

    Resolves shellscape#167

mini-css-extract-plugin reports additional, incorrect information for files that are refenced in CSS. The first time we see the file the `module.userRequest` is correct, and we add to `moduleAssets` correctly. However mini-css-extract-plugin then also reports the same `file` but with `module.userRequest` set to the CSS file that references it, which caused us to overwrite the good value in `moduleAssets`.

See the change in mini-css-extract-plugin that caused this webpack-contrib/mini-css-extract-plugin#177
    @karlvr
    karlvr committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    de5f138 View commit details
    Browse the repository at this point in the history

  2. Fix mini-css-extract-plugin 0.4.3 issue 

    Second attempt. Based on webdeveric/webpack-assets-manifest#40

Resolves shellscape#167

mini-css-extract-plugin reports additional, incorrect information for files that are refenced in CSS. The first time we see the file the `module.userRequest` is correct, and we add to `moduleAssets` correctly. However mini-css-extract-plugin then also reports the same `file` but with `module.userRequest` set to the CSS file that references it, which caused us to overwrite the good value in `moduleAssets`.

See the change in mini-css-extract-plugin that caused this webpack-contrib/mini-css-extract-plugin#177
    @karlvr
    karlvr committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    e474734 View commit details
    Browse the repository at this point in the history