Webpack 5: Add "ids" to the retrieved JSON stats #200
Conversation
) * Store custom hook in WeakMap for Webpack 5 compatability * Make unit tests run on Windows too * Expose custom hooks in Webpack 4+ through static method, update tests for Webpack 5 * Revert webpack and extract-text-webpack-plugin versions * Exclude node 6 + webpack 5 from travis matrix as they aren't compatible * Fix travis exclude rule to be exact match * Re-standardize file paths after opts.map is run * Exclude manifest in compilation assets UT from webpack 5 as feature isn't available
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 129 129
Branches 26 26
=====================================
Hits 129 129
Continue to review full report at Codecov.
|
|
@mastilver Should I add |
|
@Lyrkan Yes, I believe your PR should target |
Lyrkan
force-pushed
the
add-ids-to-stats
branch
from
0ce5fd7
to
6adbe39
Compare
|
@mastilver Changed the target branch to I also added back Hope I didn't forget anything :) |
Lyrkan
force-pushed
the
add-ids-to-stats
branch
from
629a6c4
to
ed124df
Compare
|
That's great, thank you |
This PR adds the
idsobjects to the stats retrieved bystats.toJson().It is needed by the latest alpha of Webpack 5 (
v5.0.0-alpha.31) in order to retrieveasset.chunkslater on (see webpack/webpack#9793 (review)).Without it, the following error is thrown by the plugin:
Related: #186