fix: Pass chunkGraph through in generate function
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoldberg
changed the title
chunkGraph through in generate function
shellscape
changed the title
chunkGraph through in generate functionchunkGraph through in generate function
|
Thanks for the PR. Looks like a failing test is holding this up. |
|
@shellscape Thanks for reviewing! Sorry this fell off my radar a little bit – just fixed up the test issue 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Webpack 5 deprecated a lot of the APIs that exist on chunks, and instead prefers the use of the ChunkGraph API. We have a few places where we use now-deprecated APIs in our usage of the WebpackManifestPlugin, and would like to move those over to using the ChunkGraph API.
This PR passes through the
chunkGraphin thegeneratefunction