Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1542): Add hasLabelAtTop prop #1684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(1542): Add hasLabelAtTop prop #1684

wants to merge 2 commits into from

Conversation

valsaven
Copy link

No description provided.

@valsaven
Copy link
Author

Peek 2023-03-27 14-53

@valsaven valsaven mentioned this pull request Mar 27, 2023
Open
@mattelen mattelen added the 4.0 label Mar 27, 2023
@valsaven
feat(1542): Add hasLabelAtTop prop
fad0810 
Fix placeholder alignment for multiple select variant
@USMortality
Copy link

Adding this feature is great, as I would love to have this!
One small thing: It appears to me, one of the issues with this approach might be, that it increases the height of the input, which may be problematic in some layouts. Would it be possible to place the placeholder in front of the selections?
E.g. as 'Pick badges: ' or one could add a secondary placeholder, such as 'Picked badges: '

USMortality
USMortality reviewed Oct 7, 2023
View reviewed changes
src/Multiselect.vue
@@ -311,6 +327,10 @@ export default {
)
},
isPlaceholderVisible () {
if (this.hasLabelAtTop) {
return true
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: single line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@USMortality USMortality USMortality left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valsaven @USMortality @mattelen