Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nit-picky doc typo #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

prasannavl
Copy link

No description provided.

@@ -6,7 +6,7 @@ effectively use SNAFU.

## Categorize underlying errors by their context

It should be easy to bin one underlying error type (such as
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually a typo. I'm using "bin" as a verb to mean "put into a box" / "sort" / "categorize". Can you think of a less confusing way of stating the same concept?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yikes, my bad. What do you think about wrap instead of either of them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or map, may be?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about "compartmentalize" or "classify"? I asked around at a meetup I'm at and those were suggested. We discussed "wrap" and "map", but weren't excited about "wrap" because it doesn't give the same sense of assigning one thing to multiple possible categories. "map" has some existing meaning in Rust-world with all the methods named map.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. PR updated.

@Person-93
Copy link

Maybe it should be easy to separate...? IMO, this "separate" or a similar word would be a bit clearer, but it does change the meaning slightly. So it might not be what you want...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants