Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Commonly Asked Questions page in guide. #266

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

IsaccBarker
Copy link
Contributor

Aims to fix #212 #264

Added commonly asked questions (or rather commonly encountered errors) that should be easy to build on top of. A link to this was put on the main guide page. When that is clicked, you are brought to another page, with a list of the problems.

@IsaccBarker
Copy link
Contributor Author

The failing Rust Stable seems to be code that already exists. I didn't write any code that would be run inside Snafu, only code inside the Snafu docs.

Copy link
Owner

@shepmaster shepmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the unrelated failing test and force-pushed some changes; do you think that the content still adequately conveys the intent?

.gitignore Outdated
@@ -1,3 +1,4 @@
/target
**/*.rs.bk
Cargo.lock
**.DS_STORE
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add these kinds of files to your personal global gitignore.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you didn't actually remove the .DS_Store file 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to release the .DS_Store file (: Should be no more of those (I'm on Linux now!). Anyway, I tried to forgot the solution to the problem I had, and everything I wrote just about covers it.
Sorry for not responding, Github didn't email me about this for some reason.

@shepmaster shepmaster merged commit 10ea7bf into shepmaster:master Jan 10, 2021
@shepmaster
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a troubleshooting section to the guide with common errors
2 participants