Silence -Wcast-qual warnings showing up with newer version of g++. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhen between gcc 11 and a 14 pre-release, g++ started to complain
about the C-style casts:
subprocess.h: In function ‘int subprocess_create_ex(const char* const*, int, const char* const*, subprocess_s*)’:
subprocess.h:877:27: warning: cast from type ‘const char* const*’ to type ‘char* const*’ casts away qualifiers [-Wcast-qual]
877 | (char *const *)commandLine, used_environment)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
When compiling with GCC in C-mode, the issue is still there btw. The
pragmas existing for clang are needed for GCC as well.
|
Redid the first version after the CI system revealed: the pragmas were needed after all. |
|
I might tidy that up later and put them into the const cast itself as pragmas - might be a little neater! But LGTM, will merge once green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhen between gcc 11 and a 14 pre-release, g++ started to complain about the C-style casts:
subprocess.h: In function ‘int subprocess_create_ex(const char* const*, int, const char* const*, subprocess_s*)’: subprocess.h:877:27: warning: cast from type ‘const char* const*’ to type ‘char* const*’ casts away qualifiers [-Wcast-qual]
877 | (char *const *)commandLine, used_environment)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
The pragmas for clang should not be needed anymore.