Skip to content

Commit

Permalink
deps: define OPENSSLDIR and ENGINESDIR explicitly
Browse files Browse the repository at this point in the history
According to CVE-2019-1552(*), it is encouraged to change OPENSSLDIR
from the default of /usr/local/ssl to a privileged directory on
Windows. "C:\Program Files\Common Files\SSL" is set as it is the
default path in OpenSSL-1.1.1.

(*) https://www.openssl.org/news/secadv/20190730.txt

Fixes: nodejs#29445
  • Loading branch information
shigeki committed Sep 5, 2019
1 parent 7bef222 commit d768b62
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions deps/openssl/openssl.gypi
Expand Up @@ -1274,6 +1274,8 @@
'MK1MF_BUILD',
'WIN32_LEAN_AND_MEAN',
'OPENSSL_SYSNAME_WIN32',
'ENGINESDIR="C:\\\Program\ Files\\\Common\ Files\\\SSL"',
'OPENSSLDIR="C:\\\Program\ Files\\\Common\ Files\\\SSL"',
],
'openssl_default_libraries_win': [
'-lgdi32.lib',
Expand Down

0 comments on commit d768b62

Please sign in to comment.