-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞BUG]: colorReplacements
not working on the <pre>
container
#641
Comments
colorReplacements
not working on the <pre>
containercolorReplacements
not working on the <pre>
container
It seems that colorReplacements is only used to replace code colors, you should use the bg property to replace the background color. document.querySelector<HTMLDivElement>('#app')!.innerHTML = await codeToHtml(
JSON.stringify(obj, null, 2),
{
lang: 'json',
theme: {
name: 'one-dark-pro',
bg: '#ff0000', // change the bg
},
colorReplacements: {
// This doesn't work (color on container)
'#282c34': '#ff0000',
// This works
'#e06c75': '#00ffff',
},
}
); |
How can I change the bg color for dual theme then? I only want to change the dark one. highlighter.codeToHtml(JSON.stringify(parsedJson, null, 2), {
lang: 'json',
themes: {
light: 'vitesse-light',
dark: 'material-theme-palenight',
},
colorReplacements: { '#282c34': '#141414' },
}); This doesn't seem to work: highlighter.codeToHtml(JSON.stringify(parsedJson, null, 2), {
lang: 'json',
themes: {
light: 'vitesse-light',
dark: {
name: 'material-theme-palenight',
bg: '#141414',
},
},
}); |
This won't work either, since if you use object as theme, it means a custom theme, the registered theme string as name won't work |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://togithub.com/shikijs/shiki) ([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.2.0` -> `1.3.0`](https://renovatebot.com/diffs/npm/shiki/1.2.0/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.3.0`](https://togithub.com/shikijs/shiki/releases/tag/v1.3.0) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.2.4...v1.3.0) ##### 🚀 Features - **core**: New `structure: inline` option for `codeToHast` - by [@​antfu](https://togithub.com/antfu) in [https://github.com/shikijs/shiki/issues/653](https://togithub.com/shikijs/shiki/issues/653) [<samp>(ae516)</samp>](https://togithub.com/shikijs/shiki/commit/ae516aec) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.2.4...v1.3.0) ### [`v1.2.4`](https://togithub.com/shikijs/shiki/releases/tag/v1.2.4) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.2.3...v1.2.4) *No significant changes* ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.2.3...v1.2.4) ### [`v1.2.3`](https://togithub.com/shikijs/shiki/releases/tag/v1.2.3) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.2.2...v1.2.3) ##### 🐞 Bug Fixes - `colorReplacements` also for `bg` and `fg`, close [#​641](https://togithub.com/shikijs/shiki/issues/641) - by [@​antfu](https://togithub.com/antfu) in [https://github.com/shikijs/shiki/issues/641](https://togithub.com/shikijs/shiki/issues/641) [<samp>(bb47a)</samp>](https://togithub.com/shikijs/shiki/commit/bb47a846) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.2.2...v1.2.3) ### [`v1.2.2`](https://togithub.com/shikijs/shiki/releases/tag/v1.2.2) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.2.1...v1.2.2) ##### 🚀 Features - Update deps, new `tsv` grammar - by [@​antfu](https://togithub.com/antfu) [<samp>(a7ca7)</samp>](https://togithub.com/shikijs/shiki/commit/a7ca7c32) ##### 🐞 Bug Fixes - **monaco**: Typo on interface - by [@​ije](https://togithub.com/ije) in [https://github.com/shikijs/shiki/issues/644](https://togithub.com/shikijs/shiki/issues/644) [<samp>(1fc70)</samp>](https://togithub.com/shikijs/shiki/commit/1fc70bd3) ##### 🏎 Performance - **shiki-monaco**: Improve tokenizer performance - by [@​ije](https://togithub.com/ije) in [https://github.com/shikijs/shiki/issues/645](https://togithub.com/shikijs/shiki/issues/645) [<samp>(069e0)</samp>](https://togithub.com/shikijs/shiki/commit/069e0be7) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.2.1...v1.2.2) ### [`v1.2.1`](https://togithub.com/shikijs/shiki/releases/tag/v1.2.1) [Compare Source](https://togithub.com/shikijs/shiki/compare/v1.2.0...v1.2.1) ##### 🐞 Bug Fixes - **vitepress-twoslash**: Pass `options.twoslashOptions` to `createTwoslasher` - by [@​sapphi-red](https://togithub.com/sapphi-red) in [https://github.com/shikijs/shiki/issues/637](https://togithub.com/shikijs/shiki/issues/637) [<samp>(75832)</samp>](https://togithub.com/shikijs/shiki/commit/75832e13) ##### [View changes on GitHub](https://togithub.com/shikijs/shiki/compare/v1.2.0...v1.2.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Validations
Describe the bug
Please refer to the reproduction, it's pretty clear.
Reproduction
https://stackblitz.com/edit/vitejs-vite-4byr7f?file=src%2Fmain.ts
Contributes
The text was updated successfully, but these errors were encountered: